Re: ambient_depth_filter_editor is not ignoring 'SVN_ERR_WC_PATH_NOT_FOUND' errors.

On 12/08/2010 11:02 AM, Kamesh Jayachandran wrote:
> Hi All,
>
> Prabhu got stuck with his upcoming default 'send-copy-args=True' work
> for his diff enhancements.
>
> Basically he got diff-tests-44 to fail due to
> "ambient_depth_filter_editor is *not* ignoring
> 'SVN_ERR_WC_PATH_NOT_FOUND' errors."

The ambient depth filter editor is wrapping editor with no real logic except
that which helps it to avoid calling its wrapped editor due to ambient depth
values. It is wrong for that editor to be aware of and mask any error
returned from the wrapping editor. If it was able to successfully call
open_file() or add_file() in the wrapped editor, it's reasonable to expect
that close_file() is also a legitimate function to call.

-1 on this patch.

-- 
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand