[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] fix a compilation warning

From: Hyrum K. Wright <hyrum_wright_at_mail.utexas.edu>
Date: Wed, 8 Dec 2010 16:02:27 +0000

On Wed, Dec 8, 2010 at 3:29 PM, Daniel Shahaf <d.s_at_daniel.shahaf.name> wrote:
> FWIW, my concerns here are:
> * svn_client_relocate{,2} have the same signature.  This might be
>  confusing sometimes. (but probably should be left alone)
> * svn_client_relocate2() takes an IGNORE_EXTERNALS parameter.  Should
>  we pass TRUE always to that parameter, or should we pass the
>  identically-named parameter of the calling function? (the calling
>  function *happens* to have an appropriately-named parameter, but
>  I haven't checked its semantics)

I'm of the latter persuasion, which is why I generally frown upon
updating deprecated function calls just for the sake of doing so.
Typically there are additional steps which need to happen in adjusting
the call, and adding the default parameters is not necessarily
sufficient. Keeping the deprecated call (and the attendant warning)
helps flag that "something else" needs to be done.

Received on 2010-12-08 17:03:06 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.