[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] fix a compilation warning

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Wed, 08 Dec 2010 15:50:06 +0000

Daniel Shahaf <d.s_at_daniel.shahaf.name> writes:

> * svn_client_relocate2() takes an IGNORE_EXTERNALS parameter. Should
> we pass TRUE always to that parameter, or should we pass the
> identically-named parameter of the calling function? (the calling
> function *happens* to have an appropriately-named parameter, but
> I haven't checked its semantics)

I suppose passing the ignore_externals parameter would be a good idea.
Where svn_client__update_internal calls update_internal to implement
make_parents we probably don't want externals introduced.

-- 
Philip
Received on 2010-12-08 16:50:50 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.