[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] fix a compilation warning

From: Julian Foad <julian.foad_at_wandisco.com>
Date: Wed, 08 Dec 2010 14:28:48 +0000

On Wed, 2010-12-08 at 14:26 +0000, Julian Foad wrote:
> Prabhu Gnana Sundar wrote:
> > I have attached a patch with a minor change which fixes a compiler
> > warning.
>
> Hi Prabhu. How do you know that svn_client_relocate2() is a drop-in
> replacement for svn_client_relocate() in this case? What is difference
> between svn_client_relocate() and svn_client_relocate2()? Does it
> matter? Can you think of any way of testing or verifying it?

Did you run the test suite? Does the test suite exercise this code
path?

- Julian

> > [[[
> > fix a compiler warning.
> >
> > * subversion/libsvn_client/update.c
> > (update_internal): changed the 'relocate' to 'relocate2' since
> > 'relocate' is deprecated.
> >
> > Patch by: Prabhu Gnana Sundar <prabhugs_at_collab.net>
> > Suggested by: Kamesh Jayachandran <kamesh_at_collab.net>
> > ]]]
>
>
> > Index: subversion/libsvn_client/update.c
> > ===================================================================
> > --- subversion/libsvn_client/update.c (revision 1041694)
> > +++ subversion/libsvn_client/update.c (working copy)
> > @@ -180,7 +180,7 @@
> > relocate our working copy first. */
> > if (corrected_url)
> > {
> > - SVN_ERR(svn_client_relocate(anchor_abspath, anchor_url, corrected_url,
> > + SVN_ERR(svn_client_relocate2(anchor_abspath, anchor_url, corrected_url,
> > TRUE, ctx, pool));
> > anchor_url = corrected_url;
> > }
>
Received on 2010-12-08 15:29:27 CET

This is an archived mail posted to the Subversion Dev mailing list.