[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Input validation observations

From: Julian Foad <julian.foad_at_wandisco.com>
Date: Tue, 07 Dec 2010 16:01:02 +0000

On Sat, 2010-12-04, Noorul Islam K M wrote:
> Julian Foad <julian.foad_at_wandisco.com> writes:
> > On Fri, 2010-12-03, Noorul Islam K M wrote:
> >> Julian Foad <julian.foad_at_wandisco.com> writes:
> >> > I think we should change this behaviour and make "svn update" throw an
> >> > error if any target is a URL.
> >>
> >> Attached is the patch for same.
> > [...]
> >> Make 'svn update' verify that URLs are not passed as targets.
> >>
> >> * subversion/svn/update-cmd.c,
> >> subversion/libsvn_client/update.c:
> >> (svn_cl__update, svn_client_update4): Raise an error if a URL was
> >> passed. Remove code that notifies 'Skipped' message for URL targets.
> > [...]

> Please find attached the updated patch.

Hi Noorul.

Several tests fail with this patch.

FAIL: basic_tests.py 4: basic update command
FAIL: commit_tests.py 56: 'svn commit --changelist=foo' above a
FAIL: externals_tests.py 15: should not be able to mv or rm a file
FAIL: externals_tests.py 16: place a file external into a directory

Before you send a patch, always run the test suite ("make check" or
similar) and check that all tests pass. If you have done no testing or
different testing or you found failures but want to send the patch
anyway, then simply say so in the email, so we know. If you don't say
anything, we will assume you ran the test suite and all tests pass.

Thank you.
- Julian
Received on 2010-12-07 17:01:43 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.