[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] extend svn_subst_translate_string() to record whether re-encoding and/or line ending translation were performed (v. 4)

From: Julian Foad <julian.foad_at_wandisco.com>
Date: Mon, 06 Dec 2010 18:40:34 +0000

On Tue, 2010-11-30, Danny Trebbien wrote:
> Attached is version 4 of the patch and corresponding log message that
> address Daniel Shahaf's feedback from November 9.
>
> Per a message from Julian
> (http://article.gmane.org/gmane.comp.version-control.subversion.devel/124073)
> and Daniel Shahaf
> (http://article.gmane.org/gmane.comp.version-control.subversion.devel/124082),
> I have removed the changes to optimize translate_newline() for now.

Thanks, Danny.

This looks fine.

I added doc strings to the new static functions stream_translated() and
translate_cstring(). I clarified in all doc strings whether
TRANSLATED_EOL is set to FALSE or untouched if there is no translation.
(In some cases you documented these more in the log message than in the
code :-)

Just about to commit this ... FAIL: autoprop_tests.py 15, blame_tests.py
7, commit_tests.py 40, ...

subst.c' line 668: assertion failed (STRING_IS_EOL(eol_str,
eol_str_len))

Whassup? Attaching my version, as I'm out of time tonight. Hope I
didn't mess it up. I was testing trunk_at_1042741 (patched as attached),
svnserve and FSFS, in case it matters.

Cheers,
- Julian

Received on 2010-12-06 19:41:18 CET

This is an archived mail posted to the Subversion Dev mailing list.