[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1040831 - in /subversion/trunk/subversion: include/svn_checksum.h libsvn_subr/checksum.c

From: Stefan Fuhrmann <stefanfuhrmann_at_alice-dsl.de>
Date: Sun, 05 Dec 2010 23:03:51 +0100

On 02.12.2010 12:18, Julian Foad wrote:
> A good test for whether it's worth making an API accept NULL as an input
> is: what proportion of the callers would find that useful? I see there
> are about 40 callers in the code base. Would you mind scanning through
> them and letting us know?
There were two places where the callers had to check
for NULL before calling svn_checksum_to_cstring().
I removed those checks in r1042460.

Two more places might try to call the function with a NULL
checksum under adverse conditions:

* 6x in dump_node() (subversion/libsvn_repos/dump.c)
   because the svn_fs_file_checksum() is not instructed
   to calculate missing checksums
* While constructing an error message in window_handler()

There are about ten more places where it is not entirely
crystal clear that the desired checksum is actually available.
However, I'm reasonably sure that they will in the respective
contexts (e.g. wc operations).

-- Stefan^2.
Received on 2010-12-05 23:04:28 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.