[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1041839 - in /subversion/trunk/subversion: libsvn_client/diff.c tests/cmdline/depth_tests.py tests/cmdline/diff_tests.py

From: Stefan Sperling <stsp_at_elego.de>
Date: Fri, 3 Dec 2010 23:22:33 +0100

On Fri, Dec 03, 2010 at 02:36:34PM -0000, kameshj_at_apache.org wrote:
> Author: kameshj
> Date: Fri Dec 3 14:36:33 2010
> New Revision: 1041839
>
> URL: http://svn.apache.org/viewvc?rev=1041839&view=rev
> Log:
> Follow-up to r1041068.
>
> In r1041068 I removed "." as the default path for "" to fix assertion error.
> This change is not consistent with our current behaviour(<1.6.x).
>
> In this commit I am reinstating the "." as the
> default path for ""(Revert r1041068.)
> And move default assignment of "." when path is "", after the functions
> that are not happy about "." are called.
> One optimization of avoiding recomputing 'path relative to repos_root' as one
> of the callers already has it computed.
> I do this optimization in this commit as that makes my movement of path="."
> assignment easier otherwise I would still get the assert error.

Thanks Kamesh, this looks great!

Stefan
Received on 2010-12-03 23:23:13 CET

This is an archived mail posted to the Subversion Dev mailing list.