[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Input validation observations

From: Julian Foad <julian.foad_at_wandisco.com>
Date: Fri, 03 Dec 2010 17:30:04 +0000

On Fri, 2010-12-03 at 16:53 +0000, Julian Foad wrote:
> On Fri, 2010-12-03, Julian Foad wrote:
> > On Fri, 2010-12-03 at 19:15 +0530, Noorul Islam K M wrote:
> > > Julian Foad <julian.foad_at_wandisco.com> writes:
> > > > Noorul Islam K M wrote:
> > > >> Julian Foad <julian.foad_at_wandisco.com> writes:
> > > >> > * "svn mkdir ^/ a" -> "Illegal repository URL 'a'"; should say "can't
> > > >> > mix URL and local targets"?
> > > > [...]
> > > > Does this validation make the check at the beginning of mkdir_urls()
> > > > redundant? If so, we should get rid of it.
> > >
> > > Attached is the modified patch.
> >
> > Committed in r1041900.
> >
> > Thanks!
>
> EXPECTED STDERR (regexp):
> .*Illegal repository URL 'subdir'
> ACTUAL STDERR:
> svn: Try 'svn help' for more info
> svn: Cannot mix repository and working copy targets
> FAIL: basic_tests.py 49: mkdir mix url and local path should error
>
> I'll fix it.

r1041920. And I updated issue #2586
<http://subversion.tigris.org/issues/show_bug.cgi?id=2586>.

- Julian
Received on 2010-12-03 18:30:44 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.