[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Op-depth for copies - fixing lock_tests.py 40 - in progress

From: Julian Foad <julian.foad_at_wandisco.com>
Date: Thu, 25 Nov 2010 11:44:54 +0000

On Tue, 2010-11-23, Julian Foad wrote:
> On Tue, 2010-11-23 at 18:00 +0000, Julian Foad wrote:
> > @@ -3031,8 +3057,8 @@ db_op_copy(svn_wc__db_pdh_t *src_pdh,
> > }
> >
> > if (kind == svn_wc__db_kind_dir)
> > - SVN_ERR(gather_children(&children, FALSE, src_pdh, src_relpath,
> > - scratch_pool, scratch_pool));
> > + SVN_ERR(gather_repo_children(&children, src_pdh, src_relpath,
> > dst_op_depth,
>
> Duh - should be source op-depth here, not dst_op_depth. Looks like I
> need to write some tests to ensre this is adequately exercised, as the
> current ones don't seem to be picking this up.

In r1038999 I committed a version of this patch that has
"relpath_depth(src_relpath)" here, and adds this new
gather_repo_children() but little else. That works and seems right.

- Julian
Received on 2010-11-25 12:45:34 CET

This is an archived mail posted to the Subversion Dev mailing list.