Re: [PATCH] An svn_fspath__* API for '/'-prefixed paths

On Thu, 2010-11-18, Julian Foad wrote:
> Any thoughts or concerns about this patch to add a path manipulation API
> for '/fs/relative/style' aka '/repo/relative/style' paths ...
>
> svn_fspath__is_canonical()
> svn_fspath__join()
> svn_fspath__is_child()
> svn_fspath__basename()
>
> so that we can stop abusing svn_uri_*() for this purpose, as discussed
> in the thread <http://svn.haxx.se/dev/archive-2010-11/0277.shtml>?
>
> If not, I'll commit it soon.

I first extended the patch. If FSPATH_USE_URI is defined during
compilation, the implementation forwards to the svn_uri_* API, which
could be helpful in tracking down any problems or differences that may
be encountered while porting the callers. Otherwise it uses
svn_relpath_*.

As test beyond the simle unit tests, I switched all the likely-looking
callers over to using this new API, and (after a further fix or two) it
all worked, in both compilation modes.

I committed the result (just the implementation, not callers) in
r1037662.

- Julian
Received on 2010-11-22 11:48:51 CET