Re: [PATCH] An svn_fspath__* API for '/'-prefixed paths

On Thu, Nov 18, 2010 at 06:29:56PM +0000, Julian Foad wrote:
> Any thoughts or concerns about this patch to add a path manipulation API
> for '/fs/relative/style' aka '/repo/relative/style' paths ...

> +char *
> +svn_fspath__join(const char *fspath,
> + const char *relpath,
> + apr_pool_t *result_pool)
> +{
> + assert(svn_fspath__is_canonical(fspath, result_pool));

Use SVN_ERR_ASSERT_NO_RETURN() instead of assert()?

> + assert(svn_relpath_is_canonical(relpath, result_pool));
> +
> + return svn_uri_join(fspath, relpath, result_pool);
> +}
Received on 2010-11-18 19:41:05 CET