[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] An svn_fspath__* API for '/'-prefixed paths

From: Stefan Sperling <stsp_at_elego.de>
Date: Thu, 18 Nov 2010 19:40:24 +0100

On Thu, Nov 18, 2010 at 06:29:56PM +0000, Julian Foad wrote:
> Any thoughts or concerns about this patch to add a path manipulation API
> for '/fs/relative/style' aka '/repo/relative/style' paths ...

> +char *
> +svn_fspath__join(const char *fspath,
> + const char *relpath,
> + apr_pool_t *result_pool)
> +{
> + assert(svn_fspath__is_canonical(fspath, result_pool));

Use SVN_ERR_ASSERT_NO_RETURN() instead of assert()?

> + assert(svn_relpath_is_canonical(relpath, result_pool));
> +
> + return svn_uri_join(fspath, relpath, result_pool);
> +}
Received on 2010-11-18 19:41:05 CET

This is an archived mail posted to the Subversion Dev mailing list.