[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Fix for issue 3620 - unlock command

From: Noorul Islam K M <noorul_at_collab.net>
Date: Thu, 18 Nov 2010 12:27:31 +0530

Julian Foad <julian.foad_at_wandisco.com> writes:

> On Mon, 2010-11-15, Noorul Islam K M wrote:
>
>> Noorul Islam K M <noorul_at_collab.net> writes:
>> > Noorul Islam K M <noorul_at_collab.net> writes:
>> >> Make 'svn unlock' verify that both working copy paths and URLs are
>> >> not passed.
>> >>
>> >> * subversion/tests/cmdline/input_validation_tests.py
>> >> (invalid_unlock_targets): New test, verifying that svn unlock copes well
>> >> with invalid target combinations.
>> >>
>> >> * subversion/svn/unlock-cmd.c
>> >> (svn_cl__unlock): For consistency with other sub-commands, raise the
>> >> SVN_ERR_CL_ARG_PARSING_ERROR if both working copy paths and URLs are
>> >> passed, and use the same error message also used elsewhere.
> [...]
>
> Hi Noorul. I committed this as r1035208. Thanks again for this series
> of patches.
>
>> Once this patch goes, I think we can wrap this issue.
>
> I tested by hand and found three more :-)
>
> svn patch foo ^/
> svn relocate ^/ ^/ ^/
> svn switch ^/ ^/
>
> I mentioned them in the issue:
> <http://subversion.tigris.org/issues/show_bug.cgi?id=3620>.
>
> If you'd like to address those too, that would be wonderful. You don't
> have to, of course.
>

Submitted patches for switch and relocate commands.

Thanks and Regards
Noorul
Received on 2010-11-18 08:00:04 CET

This is an archived mail posted to the Subversion Dev mailing list.