[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1036138 - /subversion/trunk/subversion/svnrdump/load_editor.c

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: Wed, 17 Nov 2010 13:22:38 -0500

On 11/17/2010 01:07 PM, Daniel Shahaf wrote:
>> - err = svn_error_create(
>> - SVN_ERR_UNSUPPORTED_FEATURE, NULL,
>> - _("Target server does not support atomic revision property "
>> - "edits; consider upgrading it to 1.7 or using an external "
>> - "locking program"));
>> + /* Pre-1.7 servers can't lock without a race condition. (Issue #3546) */
>> + svn_error_t *err =
>> + svn_error_create(SVN_ERR_UNSUPPORTED_FEATURE, NULL,
>> + _("Target server does not support atomic revision "
>> + "property edits; consider upgrading it to 1.7 "
>> + "or using an external locking program"));
>
> Hmm. I realize this is preexisting code, but the bit about "external
> locking" doesn't apply to svnrdump, since unlike svnsync it doesn't have
> a --use-external-locking flag.

I *knew* there was something I had made a mental note to remove. When I
went back later to do so, I'd forgotten what it was. Thanks for the
reminder! Will fix in a bit -- got another change in progress here.

-- 
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

Received on 2010-11-17 19:23:17 CET

This is an archived mail posted to the Subversion Dev mailing list.