[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1033622 - /subversion/trunk/subversion/tests/libsvn_fs_fs/fs-pack-test.c

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: Wed, 10 Nov 2010 13:28:31 -0500

On 11/10/2010 01:19 PM, Daniel Shahaf wrote:
> cmpilato_at_apache.org wrote on Wed, Nov 10, 2010 at 18:08:17 -0000:
>> + err = svn_fs_recover(REPO_NAME, NULL, NULL, pool);
>> + if (! err)
>> + return svn_error_create(SVN_ERR_TEST_FAILED, NULL,
>> + "Expected SVN_ERR_FS_CORRUPT error; got none");
>> + if (err->apr_err != SVN_ERR_FS_CORRUPT)
>> + return svn_error_create(SVN_ERR_TEST_FAILED, err,
>> + "Expected SVN_ERR_FS_CORRUPT error; got:");
>
> Suppose err->apr_err == SVN_ERR_FS_CORRUPT, won't that leak the error?

Yup. Fixed in r1033632. (Thanks.)

-- 
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

Received on 2010-11-10 19:29:12 CET

This is an archived mail posted to the Subversion Dev mailing list.