On Wed, 2010-11-10, Noorul Islam K M wrote:
> Julian Foad <julian.foad_at_wandisco.com> writes:
[...]
> > So I think it would be good if you could create a function that
> > encapsulates the svn_opt_parse_path() and the new "if(url)..."
> > statements. It could be called svn_cl__parse_path(), and it could live
> > in subversion/svn/util.c.
> >
> > Then the svn client code could call it instead of svn_opt_parse_path().
>
> I implemented the same and attached is the patch.
Thanks! Committed revision 1033411. (I tweaked the log message wording
a little bit to my taste.)
- Julian
> Log
>
> [[[
> New wrapper function svn_cl__opt_parse_path() for
> svn_opt_parse_path(), which canonicalizes dirent/URL.
>
> Make use of new function in "ls" and "cat" commands.
>
> * subversion/svn/cl.h
> (svn_cl__opt_parse_path): New function.
>
> * subversion/svn/util.c
> (svn_cl__opt_parse_path): New function.
>
> * subversion/svn/list-cmd.c
> (svn_cl__list),
> * subversion/svn/cat-cmd.c
> (svn_cl__cat): Use wrapper function svn_cl__opt_parse_path() instead
> of svn_opt_parse_path()
>
> Suggested by: Julian Foad <julian.foad{_AT_}wandisco.com>
> Patch by: Noorul Islam K M <noorul{_AT_}collab.net>
>
> ]]]
Received on 2010-11-10 12:05:26 CET