[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: svn_tristate_t Re: svn commit: r1033006 - /subversion/trunk/subversion/include/svn_types.h

From: Bert Huijben <bert_at_qqmail.nl>
Date: Wed, 10 Nov 2010 11:14:50 +0100

> -----Original Message-----
> From: Daniel Shahaf [mailto:d.s_at_daniel.shahaf.name]
> Sent: woensdag 10 november 2010 0:26
> To: dev_at_subversion.apache.org
> Cc: Daniel Shahaf
> Subject: Re: svn_tristate_t Re: svn commit: r1033006 -
> /subversion/trunk/subversion/include/svn_types.h
>
> Daniel Shahaf wrote on Wed, Nov 10, 2010 at 00:31:11 +0200:
> > I see us someday pcalloc()'ing one of these and forgetting to reset
> it
> > to the 'svn_tristate_unknown' value.
>
> Actually, svn_log_changed_path2_create() does exactly this. Right now.

When I introduced svn_tristate_t, 0 was the unknown value...
(And this might have been the reason to do that... but I don't remember the
exact reasoning any more)

        Bert
Received on 2010-11-10 11:15:35 CET

This is an archived mail posted to the Subversion Dev mailing list.