[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix Windows test failures - Python test suite bug in quoting a trailing backslash

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Tue, 9 Nov 2010 20:20:55 +0200

Julian Foad wrote on Tue, Nov 09, 2010 at 12:07:16 +0000:
> (We like to be able to copy and paste and run the displayed command.)

I recall two oddities (at least in -v mode) in the Python tests:

* Sometimes they gave to absolute path to atomic-ra-revprop-change (the
  compiled helper) and sometimes just its basename.

* Arguments containing spaces weren't always quoted properly.

Here's an example (after changing atomic_over_ra()'s expectations
such that it FAILs):

% ./prop_tests.py -v 34
CMD: atomic-ra-revprop-change file:///home/daniel/src/svn/t20/subversion/tests/cmdline/svn-test-work/repositories/prop_tests-34 0 flower "( 11 old_value_p 0 5 value 11 wrong value )" serf 0
CMD: /home/daniel/src/svn/t20/subversion/tests/cmdline/atomic-ra-revprop-change file:///home/daniel/src/svn/t20/subversion/tests/cmdline/svn-test-work/repositories/prop_tests-34 0 flower ( 11 old_value_p 0 5 value 11 wrong value ) serf 0 exited with 1

Ideally, I'd want this:

CMD: /home/daniel/src/svn/t20/subversion/tests/cmdline/atomic-ra-revprop-change
file:///home/daniel/src/svn/t20/subversion/tests/cmdline/svn-test-work/repositories/prop_tests-34
0 flower "( 11 old_value_p 0 5 value 11 wrong value )" serf 0

plus some indication of the exit code if appropriate.

Haven't tested with your patch yet, sorry. If it doesn't cover that,
I can take a look later.

Daniel
Received on 2010-11-09 19:24:00 CET

This is an archived mail posted to the Subversion Dev mailing list.