[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] mailer.py : Use python difflib.unified_diff instead of *nix diff command

From: Kamesh Jayachandran <kamesh_at_collab.net>
Date: Mon, 08 Nov 2010 19:13:34 +0530

On 11/05/2010 09:45 PM, Noorul Islam K M wrote:
> [[[
>
> If diff command does not exist on the system then use
> difflib.unified_diff() to generate diff contents.
>
> * tools/hook-scripts/mailer/mailer.py: Fall back to
> difflib.unified_diff() if the script fails to execute native 'diff'
> command.
>
> Patch by: Noorul Islam K M<noorul{_AT_}collab.net>
> Suggested by: Kamesh Jayachandran<kamesh{_AT_}collab.net>
>
> ]]]
Thanks for the patch Noorul.

I could not *see* the difference in the output. I tried with few file
mod commit mails both via external diff and difflib.

I committed this patch with small refactoring at r1032568.

With regards
Kamesh Jayachandran
Received on 2010-11-08 14:46:02 CET

This is an archived mail posted to the Subversion Dev mailing list.