[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: ctypes-python bindings test cases issue.

From: Noorul Islam K M <noorul_at_collab.net>
Date: Fri, 05 Nov 2010 21:12:34 +0530

Philip Martin <philip.martin_at_wandisco.com> writes:

> Daniel Shahaf <d.s_at_daniel.shahaf.name> writes:
>
>>> > handle. Solutions include:
>>> >
>>> > - adding an svn_repos_close API
>>> > - clearing or destroying the pool passed to svn_repos_create
>>> > - having the test create repositories at different locations
>>>
>>> I have implemented the last solution and attached is the patch for the
>>> same.
>>
>> I think Philip was just enumerating all possible solutions. I think
>> making the test suite avoid the problem is the wrong solution --- it
>> would be better to cause those dangling handles to get closed at the
>> appropriate time (e.g., when there are no more references to the Python
>> repos object).
>
> It may be as simple as
>
> Index: ../src/subversion/bindings/ctypes-python/test/wc.py
> ===================================================================
> --- ../src/subversion/bindings/ctypes-python/test/wc.py (revision 1031593)
> +++ ../src/subversion/bindings/ctypes-python/test/wc.py (working copy)
> @@ -72,6 +72,7 @@
> if os.path.exists(wc_location):
> svn_io_remove_dir(wc_location, pool)
> if os.path.exists(repos_location):
> + self.repos = None
> svn_repos_delete(repos_location, pool)
> self.wc = None
>

This did not solve the problem. I still get the disk I/O error.

>
> I don't know how to run the ctypes tests.

make check-ctypes-python

Thanks and Regards
Noorul
Received on 2010-11-05 16:43:35 CET

This is an archived mail posted to the Subversion Dev mailing list.