[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1031035 - /subversion/trunk/subversion/libsvn_wc/wc_db.c

From: Hyrum K. Wright <hyrum_wright_at_mail.utexas.edu>
Date: Thu, 4 Nov 2010 12:48:00 -0500

On Thu, Nov 4, 2010 at 10:54 AM, Bert Huijben <bert_at_qqmail.nl> wrote:
>
>
>> -----Original Message-----
>> From: hwright_at_apache.org [mailto:hwright_at_apache.org]
>> Sent: donderdag 4 november 2010 16:31
>> To: commits_at_subversion.apache.org
>> Subject: svn commit: r1031035 -
>> /subversion/trunk/subversion/libsvn_wc/wc_db.c
>>
>> Author: hwright
>> Date: Thu Nov  4 15:31:14 2010
>> New Revision: 1031035
>>
>> URL: http://svn.apache.org/viewvc?rev=1031035&view=rev
>> Log:
>> Rewrite svn_wc__db_read_kind() to efficiently fetch the node kind,
>> rather than
>> go through read_info() to do so.
>
> Does this still provide a measureable performance improvement these days?
>
> We used to fetch BASE, WORKING and ACTUAL as separate statements some time ago, but a _read_info() asking for just status should only fetch this row now.

I was mainly focused on removing all the conditionals in read_info()
function. I haven't measured any performance improvements or lack
thereof. (Though I suspect that all the conditionals do throw off
branch predictors.)

-Hyrum
Received on 2010-11-04 18:48:40 CET

This is an archived mail posted to the Subversion Dev mailing list.