Re: [PATCH] introduce AuthzSVNRepoRelativeAccessFile configuration item for mod_authz_svn

(This doesn't appear to have come through to the list after a day, so
I'm resending it from a different MUA.)

On 01/11/10 15:56, Philip Martin wrote:

> The name should be AuthzSVNReposRelativeAccessFile for consistency with
> SVNReposName.
>
> It should be an error to specify both AuthzSVNAccessFile and
> AuthzSVNReposRelativeAccessFile similar to SVNPath/SVNParentPath.
>
> Perhaps it should be a path rather than a boolean?

I've addressed all these comments, including this one to convert the
argument to be a path rather than a boolean.

New patch is:

[[[
Implement AuthzSVNReposRelativeAccessFile to allow SVNParentPath to use
a different authz configuration file for each repository.

* subversion/mod_authz_svn/mod_authz_svn.c
  (get_access_conf): Check if AuthzSVNReposRelativeAccessFile is used,
  and if so, load the authz file from inside the repository being
  accessed rather than one which is statically configured in the
  Apache configuration.
  (subreq_bypass, access_checker, check_user_id, auth_checker):
  Recognise that it's valid not to have a AuthzSVNAccessFile if
  AuthzSVNReposRelativeAccessFile is used.
  (AuthzSVNAccessFile_cmd, AuthzSVNReposRelativeAccessFile_cmd):
  Introduce functions to ensure AuthzSVNAccessFile and
  AuthzSVNReposRelativeAccessFile are not used at the same time.
]]]

Regards,

 Nick