[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Fix for issue 3609

From: Noorul Islam K M <noorul_at_collab.net>
Date: Tue, 02 Nov 2010 16:05:32 +0530

"Bert Huijben" <bert_at_qqmail.nl> writes:

>> -----Original Message-----
>> From: Noorul Islam K M [mailto:noorul_at_collab.net]
>> Sent: dinsdag 2 november 2010 11:08
>> To: dev_at_subversion.apache.org
>> Subject: [PATCH] Fix for issue 3609
>>
>>
>> Log
>>
>> [[[
>>
>> Fix issue 3609: Canonicalize url
>>
>> * subversion/svn/info-cmd.c
>> (svn_cl__info): Canonicalize url before passing over to API
>>
>> Patch by: Noorul Islam K M <noorul{_AT_}collab.net>
>>
>> ]]]
>
> true_path can be a url or a local path. On Windows calling
> svn_uri_canonicalize() breaks UNC paths like '//server/share/path'.
>
> I think the code could use a svn_path_is_url() call to check if the path is
> a url before calling svn_uri_canonicalize().
>

Attached is the updated patch. No change in log message. Thank you for
the comment.

Thanks and Regards
Noorul

Index: subversion/svn/info-cmd.c
===================================================================
--- subversion/svn/info-cmd.c (revision 1029983)
+++ subversion/svn/info-cmd.c (working copy)
@@ -538,6 +538,9 @@
       /* Get peg revisions. */
       SVN_ERR(svn_opt_parse_path(&peg_revision, &truepath, target, subpool));
 
+ if (svn_path_is_url(truepath))
+ truepath = svn_uri_canonicalize(truepath, subpool);
+
       /* If no peg-rev was attached to a URL target, then assume HEAD. */
       if (svn_path_is_url(target))
         {
Received on 2010-11-02 11:38:04 CET

This is an archived mail posted to the Subversion Dev mailing list.