[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] Indentation error in swig binding

From: prabhugnanasundar <prabhugs_at_collab.net>
Date: Mon, 01 Nov 2010 17:19:35 +0530

Hi,

I am using Debian Lenny. I get swig 1.3.25 with it by default. When I
try to install the swig-py, I get indentation error at core.py file
(line 3178). Since it is an auto generated code from core.i file,
modifying the core.i file solved the problem.
My friend uses swig 1.3.40 which comes with Fedora core 13. In that
version everything works fine even if the indentation is changed at
will. Though in swig 1.3.25 it works iff the indentation is proper.
Hence the problem can be solved by indenting the core.i file.

In r911480 rdonch has fixed an indentation error which he claims has
solved the problem. But he did not mention the swig version. He has
changed the indentation from two to three, but that does not work for
swig 1.3.25. Hope my patch solves everyone's problem. I have the log and
the patch as follows...

[[[
Clear the indentation problem in swig
* subversion/bindings/swig/core.i
  (svn_auth_open): The default indentation of the file is found to be 2.
                   subversion/bindings/swig/python/libsvn/core.py file
                   generates indentation of 4.

Patch by: Prabhu Gnana Sundar <prabhugs_at_collab.net>
]]]

Index: subversion/bindings/swig/core.i
===================================================================
--- subversion/bindings/swig/core.i (revision 1029575)
+++ subversion/bindings/swig/core.i (working copy)
@@ -751,7 +751,7 @@
# references to the providers are gone, they will still be alive,
# keeping the baton valid.
%feature("pythonappend") svn_auth_open %{
- val.__dict__["_deps"] = list(args[0])
+ val.__dict__["_deps"] = list(args[0])
%}
#endif

Please do get back to me about this.

Regards,
Prabhu
Received on 2010-11-01 12:50:17 CET

This is an archived mail posted to the Subversion Dev mailing list.