[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1029232 - /subversion/branches/performance/subversion/libsvn_fs_util/caching.c

From: Hyrum K. Wright <hyrum_wright_at_mail.utexas.edu>
Date: Sat, 30 Oct 2010 22:12:21 -0500

On Sat, Oct 30, 2010 at 8:24 PM, <danielsh_at_apache.org> wrote:
> Author: danielsh
> Date: Sun Oct 31 01:24:31 2010
> New Revision: 1029232
>
> URL: http://svn.apache.org/viewvc?rev=1029232&view=rev
> Log:
> On the 'performance' branch:
>
> * subversion/libsvn_fs_util/caching.c
>  (svn_fs__get_global_membuffer_cache):
>    Ensure that a 64 bit number is divided before being casted.
>
> Modified:
>    subversion/branches/performance/subversion/libsvn_fs_util/caching.c
>
> Modified: subversion/branches/performance/subversion/libsvn_fs_util/caching.c
> URL: http://svn.apache.org/viewvc/subversion/branches/performance/subversion/libsvn_fs_util/caching.c?rev=1029232&r1=1029231&r2=1029232&view=diff
> ==============================================================================
> --- subversion/branches/performance/subversion/libsvn_fs_util/caching.c (original)
> +++ subversion/branches/performance/subversion/libsvn_fs_util/caching.c Sun Oct 31 01:24:31 2010
> @@ -78,7 +78,7 @@ svn_fs__get_global_membuffer_cache(void)
>       svn_cache__membuffer_cache_create
>           (&cache,
>            (apr_size_t)cache_size,
> -           (apr_size_t)cache_size / 16,
> +           (apr_size_t)(cache_size / 16),

Magic number? (Or, if we're just interested in shifting the bits by a
nibble, let's do that instead.)

>            ! svn_fs_get_cache_config()->single_threaded,
>            pool);
>     }
>
>
>
Received on 2010-10-31 04:12:59 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.