On Thu, Oct 28, 2010 at 5:25 PM, Philip Martin
<philip.martin_at_wandisco.com> wrote:
> "C. Michael Pilato" <cmpilato_at_collab.net> writes:
>
>> On 10/28/2010 04:54 PM, cmpilato_at_apache.org wrote:
>>> Author: cmpilato
>>> Date: Thu Oct 28 20:54:14 2010
>>> New Revision: 1028472
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1028472&view=rev
>>> Log:
>>> Fix issue #3597 -- "relocate should update externals from the same
>>> repository, too".
>>
>> Heads up! This broke the javahl build. API changes requiring bindings
>> love, etc. I'm lost in that world, but will try to correct the problem
>> tomorrow if nobody beats me to it.
>
> I don't know whether we should pass TRUE or FALSE:
>
> Index: subversion/bindings/javahl/native/SVNClient.cpp
> ===================================================================
> --- subversion/bindings/javahl/native/SVNClient.cpp (revision 1028508)
> +++ subversion/bindings/javahl/native/SVNClient.cpp (working copy)
> @@ -1171,7 +1171,7 @@
> return;
>
> SVN_JNI_ERR(svn_client_relocate2(intPath.c_str(), intFrom.c_str(),
> - intTo.c_str(), ctx,
> + intTo.c_str(), FALSE, ctx,
> requestPool.pool()), );
> }
When in doubt: ask the user! I've pushed this parameter up to the
JavaHL API level in r1028568.
But I also find it useful to just look at the C backward compat
wrapper, and follow the example therein.
-Hyrum
Received on 2010-10-29 03:03:23 CEST