[RFC] Eliminate scan_base_repos() - require repos-id and repos-relpath in all BASE nodes

Bert and Erik and Philip and I discussed on IRC today the merits, or
lack of merits, of allowing repos-id/repos-relpath to be elided in the
NODES table BASE layer (op_depth = 0).

* The data is not currently elided.

* Some queries for locks currently assume the data is not elided.

* Elision could save a bit of DB size, which *might* contribute to a
little bit of general DB performance.

* The option of elision results in the need for all users of this data
to call svn_wc__db_scan_base_repos() or the internal version
scan_upwards_for_repos(), which is an extra maintenance burden and extra
run-time cost.

We concluded it would be better to require the columns to be always
filled in. I'll do this soon if no objections.

- Julian
Received on 2010-10-28 17:09:51 CEST