Re: svn commit: r1027896 - /subversion/trunk/subversion/tests/libsvn_wc/op-depth-test.c

Blair Zajac <blair_at_orcaware.com> writes:

> On 10/27/2010 09:52 AM, Philip Martin wrote:
>> "Hyrum K. Wright"<hyrum_wright_at_mail.utexas.edu> writes:
>>
>>>> + const char source_copied_file[] = "A/B/lambda-copied";
>>>> + const char source_copied_dir[] = "A/B/E-copied";
>>>>
>>>> -#define source_copied_file "A/B/lambda-copied"
>>>> -#define source_copied_dir "A/B/E-copied"
>>>> + SVN_ERR(add_and_commit_greek_tree(b));
>>>>
>>>> /* Create the various kinds of source node which will be copied */
>>>
>>> Nice change, but minor style nit: I think we use 'const char *' for
>>> these types of expressions, instead of the array syntax. (Or at
>>> least, I prefer the former :)
>>
>> The reason Julian used #define is that a 'const char *' cannot later be
>> used as an initializer; 'const char []' can.
>
> While we're talking style nits, making these static would be nice also :)

Ah, yes. Making them static would allow them to be 'const char *' as
well.

-- 
Philip