[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1027896 - /subversion/trunk/subversion/tests/libsvn_wc/op-depth-test.c

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Wed, 27 Oct 2010 17:52:56 +0100

"Hyrum K. Wright" <hyrum_wright_at_mail.utexas.edu> writes:

>> +  const char source_copied_file[] = "A/B/lambda-copied";
>> +  const char source_copied_dir[]  = "A/B/E-copied";
>>
>> -#define source_copied_file "A/B/lambda-copied"
>> -#define source_copied_dir  "A/B/E-copied"
>> +  SVN_ERR(add_and_commit_greek_tree(b));
>>
>>   /* Create the various kinds of source node which will be copied */
>
> Nice change, but minor style nit: I think we use 'const char *' for
> these types of expressions, instead of the array syntax. (Or at
> least, I prefer the former :)

The reason Julian used #define is that a 'const char *' cannot later be
used as an initializer; 'const char []' can.

-- 
Philip
Received on 2010-10-27 18:53:41 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.