[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn patch --strip-count=N or svn patch --strip=N?

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: Mon, 25 Oct 2010 09:50:41 -0400

On 10/25/2010 09:39 AM, Stefan Sperling wrote:
> On Mon, Oct 25, 2010 at 01:16:29PM +0100, Julian Foad wrote:
>> Do we need both "--strip-count" and "--strip" as aliases? I think
>> "--strip" is sufficient; the word "count" doesn't add much. "--strip"
>> matches GNU patch. Fewer aliases -> better.
>
> The word "count" adds something when you're looking at all options
> in isolation of their subcommands (option names are global).

I agree, to a point. It's not as if we display the --strip-count option
anywhere except in the usage message of the one context where it is valid,
though.

> The --strip-count name matches the variable name in the code.

Er... This is a non-reason. :-)

I don't think it's so terribly important to match the 'patch' command's
option name with our option's primary name, but it's a nice-to-have
achievable via the option aliases. If we're going to go that route, though,
then we should choose an option's primary name as if there was nothing else
to model after. I mean, is --strip-count as descriptive as it can be, or
would something else serve better? --strip-components-count?
--ignore-path-components-count?

*shrug*

-- 
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

Received on 2010-10-25 15:51:34 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.