[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1026128 - /subversion/trunk/subversion/libsvn_wc/adm_ops.c

From: Erik Huelsmann <ehuels_at_gmail.com>
Date: Fri, 22 Oct 2010 09:51:47 +0200

>> -  if (! replaced && status == svn_wc__db_status_added
>> +  if (reverted
>> +      && ! replaced
>> +      && status == svn_wc__db_status_added
>>        && db_kind == svn_wc__db_kind_dir)
>>      {
>> -      /* Non-replacements have their admin area deleted. wc-1.0 */
>> +      /* Non-replaced directories have their admin area deleted. wc-
>> 1.0 */
>>        SVN_ERR(svn_wc__adm_destroy(db, local_abspath,
>>                                    cancel_func, cancel_baton, pool));
>>      }
>>
>
> I don't think we need this block with single-db. There is no administrative area to remove.

This call also destroys the adm-access which may be cached in the
db-handle. Removing that call makes one of our 'we should work with
our old entries code' tests fail. Maybe the comment should state
something to that effect?

Bye,

Erik.
Received on 2010-10-22 09:52:26 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.