Re: svn commit: r1004286 - in /subversion/trunk: ./ subversion/libsvn_subr/io.c

Ramkumar Ramachandra <artagnon_at_gmail.com> writes:

> Hi Philip,
>
> [sorry about the delayed reply; was ill]
>
> Philip Martin writes:
>> Ramkumar Ramachandra <artagnon_at_gmail.com> writes:
>> > Hm. I read up a little more about this, but what confuses me is-
>> > shouldn't the rest of the code already be needing this?
>>
>> I don't understand your questions. To what does "rest of the code"
>> refer?
>
> What I meant is that the rest of the functions in io.c should also
> have to handle atomicity. I see svn_io_temp_dir using
> svn_atomic__init_once for example.

Most of the functions don't share any state between threads, so they
have no atomic issues. svn_io_temp_dir is one of the few that does,
so it uses svn_atomic__init_once. I think the file perms stuff should
also use it.

-- 
Philip