[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] Simplify WC DB function start_directory_update_txn()

From: Julian Foad <julian.foad_at_wandisco.com>
Date: Thu, 14 Oct 2010 23:32:15 +0100

Hi Bert.

Any objection to me simplifying start_directory_update_txn(), as in the
attached patch? It appears that it's doing relatively a lot of work
every time just to decide whether the repos_relpath is going to be the
same as before, and thus decide whether to use a different update
statement that omits that parameter. It seems to that the work done,
and the code complexity, must far outweigh the cost of simply providing
the parameter every time. Am I missing something? I haven't profiled
it, as it looks like an obvious win.

I'll commit if no objection.

- Julian

Received on 2010-10-15 00:33:01 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.