Re: svn commit: r1003986 [1/2] - in /subversion/trunk/subversion: libsvn_client/ libsvn_fs_base/ libsvn_fs_base/bdb/ libsvn_fs_fs/ libsvn_ra_local/ libsvn_ra_neon/ libsvn_ra_serf/ libsvn_ra_svn/ libsvn_repos/ libsvn_subr/ libsvn_wc/ mod_authz_svn/ mo

On Mon, Oct 04, 2010 at 09:42:01AM -0500, Hyrum K. Wright wrote:
> On Mon, Oct 4, 2010 at 5:14 AM, Julian Foad <julian.foad_at_wandisco.com> wrote:
> > I'm glad you are keen to keep only relevant warnings visible, but the
> > sight of so many unnecessary casts in our code makes me squirm. :-(
> >
> > The NULL macro is intended for use as a pointer.  When a combination of
> > compiler, system library headers and APR headers conspires to throw out
> > lots of warnings for perfectly normal code, it is that combination that
> > needs to be fixed, not our code.
>
> I agree. Keeping this usage consistent has the potential of being a
> maintenance nightmare. Fixing the cause, rather than the symptom,
> should be the priority.

OK. No time to revert it right now, will do it later tonight or tomorrow.

Stefan
Received on 2010-10-04 18:17:19 CEST