Re: svn commit: r1003924 - /subversion/trunk/subversion/svnrdump/dump_editor.c

Hi Bert,

Bert Huijben writes:
> Do you really need a 'named' file here?
>
> The named file algorithm of svn_io_open_uniquely_named() is very slow compared to the 'just get me a temporary file' implemented by svn_io_open_unique_file3(). Especially when you need more than a few tempfiles with the same basename. (It tries the generated name itself, then it tries a 1 suffix, a 2 suffix, etc. Until it finds a name that doesn't exist)

Ah, I see. The named temporary made debugging easier initially- I
could easily see if the file was being removed or not, but I suppose
it doesn't matter anymore. Fixed in r1003958. Thanks for the
suggestion.

-- Ram
Received on 2010-10-03 15:09:13 CEST