[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1002470 - /subversion/trunk/subversion/svnrdump/dump_editor.c

From: Ramkumar Ramachandra <artagnon_at_gmail.com>
Date: Wed, 29 Sep 2010 13:34:21 +0530

Hi Daniel,

Daniel Shahaf writes:
> So, you use a top-level pool but never destroy it?
>
> That's not good.
>
> Can you please find another solution? (Either get the caller to
> guarantee something about the lifetime of the pool they provide (there
> is precedent for this), or figure out why close_edit() isn't called (and
> possibly patch the faulty driver).

Fixed in r1002502 :)

Thanks for the review.

-- Ram
Received on 2010-09-29 10:06:14 CEST

This is an archived mail posted to the Subversion Dev mailing list.