[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn propchange: r1001678 - svn:log

From: Greg Stein <gstein_at_gmail.com>
Date: Tue, 28 Sep 2010 05:54:42 -0400

Why are tests failing because of the different values?

Philip stated that we weren't really examining the values. That "zero
vs non-zero" was the only real test so far. So why does inserting
other values break things? That seems to be a more interesting problem
to solve than simply throwing up our collective hands and #ifdef'ing
the values out (along with that additional complexity!)

Cheers,
-g

On Mon, Sep 27, 2010 at 07:58, <julianfoad_at_apache.org> wrote:
> Author: julianfoad
> Revision: 1001678
> Modified property: svn:log
>
> Modified: svn:log at Mon Sep 27 11:58:18 2010
> ------------------------------------------------------------------------------
> --- svn:log (original)
> +++ svn:log Mon Sep 27 11:58:18 2010
> @@ -1,2 +1,12 @@
> +Guard some ongoing op_depth work inside a new conditional: SVN_WC__OP_DEPTH.
> +Guards the change made in r1000557, but not yet the similar changes made in
> +r1000955.  These op_depth changes are causing test failures, and the fixes
> +are expected to be extensive.
> +
> +Also document an existing function.
> +
>  * subversion/libsvn_wc/wc_db.c
>   (construct_like_arg): Add a doc string. Fix naming of the pool arg.
> +  (svn_wc__db_op_add_directory, svn_wc__db_op_add_file,
> +   svn_wc__db_op_add_symlink): Change op_depth back to a hard-coded '2'
> +    unless SVN_WC__OP_DEPTH is defined.
>
>
Received on 2010-09-28 11:55:24 CEST

This is an archived mail posted to the Subversion Dev mailing list.