[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[WIP] Gracefully handle svn_wc_prop_set4() errors in svn patch

From: Daniel Näslund <daniel_at_longitudo.com>
Date: Mon, 27 Sep 2010 22:09:26 +0200

Hi!

Questions
-------------
* Is it sane to add a svn_wc_notify_failed_prop_patch action for this
  special case? We're starting to have a lot of actions.

* What is wrong with the way I handle the error? I hit err_abort() when
  the program terminates. (I'm expecting the answer to hurt a bit - this
  is surely something that I should have understood by now). I thought
  that since the error is allocated on the heap I could just store the
  pointer to it and free it later, e.g. call svn_error_clear().

[[[
Print a warning instead of error out if a property could not be set on a
path with 'svn patch'.

* subversion/svn/notify.c
  (notify): Add svn_wc_notify_failed_prop_patch case.

* subversion/include/svn_wc.h
  (svn_wc_notify_action_t): Add svn_wc_notify_failed_prop_patch field.
  (svn_wc_notify_t): Update doc string for 'err' field to mention that
    it is set for svn_wc_notify_failed_prop_patch.

* subversion/libsvn_client/patch.c
  (prop_patch_target_t): Add 'was_rejected' and 'err' field to record
    failed property patches.
  (send_patch_notification): Send svn_wc_notify_failed_prop_patch
    notifications.
  (install_patched_prop_targets): Record failed propsets.
]]]

Daniel

Received on 2010-09-27 22:10:16 CEST

This is an archived mail posted to the Subversion Dev mailing list.