[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r999785 - /subversion/trunk/subversion/libsvn_subr/svn_string.c

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Wed, 22 Sep 2010 12:38:58 +0200

stylesen_at_apache.org wrote on Wed, Sep 22, 2010 at 07:17:51 -0000:
> Author: stylesen
> Date: Wed Sep 22 07:17:51 2010
> New Revision: 999785
>
> URL: http://svn.apache.org/viewvc?rev=999785&view=rev
> Log:
> Fix a warning.
>
> * subversion/libsvn_subr/svn_string.c
> (svn_cstring_strtoui64, svn_cstring_strtoi64): Use proper format
> specifiers while returning the error.
>
> Modified:
> subversion/trunk/subversion/libsvn_subr/svn_string.c
>
> Modified: subversion/trunk/subversion/libsvn_subr/svn_string.c
> URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_subr/svn_string.c?rev=999785&r1=999784&r2=999785&view=diff
> ==============================================================================
> --- subversion/trunk/subversion/libsvn_subr/svn_string.c (original)
> +++ subversion/trunk/subversion/libsvn_subr/svn_string.c Wed Sep 22 07:17:51 2010
> @@ -661,7 +661,7 @@ svn_cstring_strtoui64(apr_uint64_t *n, c
> val < 0 || (apr_uint64_t)val < minval || (apr_uint64_t)val > maxval)
> return svn_error_return(
> svn_error_createf(SVN_ERR_INCORRECT_PARAMS, NULL,
> - _("Number '%s' is out of range '[%lu, %lu]'"),
> + _("Number '%s' is out of range '[%llu, %llu]'"),
> str, minval, maxval));

minval is an apr_uint64_t, so shouldn't the format string use APR_UINT64_FMT?

> *n = val;
> return SVN_NO_ERROR;
> @@ -705,7 +705,7 @@ svn_cstring_strtoi64(apr_int64_t *n, con
> val < minval || val > maxval)
> return svn_error_return(
> svn_error_createf(SVN_ERR_INCORRECT_PARAMS, NULL,
> - _("Number '%s' is out of range '[%ld, %ld]'"),
> + _("Number '%s' is out of range '[%lld, %lld]'"),
> str, minval, maxval));
> *n = val;
> return SVN_NO_ERROR;
>
>
Received on 2010-09-22 12:40:02 CEST

This is an archived mail posted to the Subversion Dev mailing list.