[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: [PATCH 3/3] atomic-revprop: Signal the error as a HTTP status code

From: Jon Foster <Jon.Foster_at_cabot.co.uk>
Date: Tue, 21 Sep 2010 13:49:31 +0100

Julian Reschke wrote:
> On 21.09.2010 14:12, Daniel Shahaf wrote:
> > Julian Reschke wrote on Tue, Sep 21, 2010 at 13:46:13 +0200:
> >> Hi,
> >>
> >> just two comments without having looked at the remainder of the
discussion.
> >>
> >> 1) If you need to augment a standard HTTP response code with
additional
> >> information, the right thing to use is DAV:error (see
> >> <http://greenbytes.de/tech/webdav/rfc4918.html#rfc.section.16>).
> >>
> >
> > What does that gain us? As Jon said elsethread, generic DAV clients
> > aren't going to be making requests with V:old-value set.
>
> I was just offering an option that may be cleaner than overloading the

> semantics of other fields.
>
> Also, if this is *purely* for SVN, another obvious solution is just to

> add an extension element to the DAV:response element (in teh SVN
> namespace...).

(Background: For this discussion, we're only talking about how we
return PROPPATCH errors inside the 207 Multi-Status envelope).

Unfortunately, we're severely constrained by mod_dav and
ra_neon. In particular, see mod_dav's dav_failed_proppatch()
function, here:

http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/dav/main/mod_dav.
c?revision=982016&view=markup#l2121

This is the mod_dav function that builds the 207 response
from a failed PROPPATCH. It doesn't allow us to add extra
XML wherever we want; we only get to set the <D:status>
number and insert some text inside <D:responsedescription>.
We *could* insert XML inside the <D:responsedescription>,
but that would break all existing SVN clients.

Kind regards,

Jon

**********************************************************************
This email and its attachments may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of Cabot Communications Ltd.

If you are not the intended recipient of this email and its attachments, you must take no action based upon them, nor must you copy or show them to anyone.

Cabot Communications Limited
Verona House, Filwood Road, Bristol BS16 3RY, UK
+44 (0) 1179584232

Co. Registered in England number 02817269

Please contact the sender if you believe you have received this email in error.

**********************************************************************

______________________________________________________________________
This email has been scanned by the MessageLabs Email Security System.
For more information please visit http://www.messagelabs.com/email
______________________________________________________________________
Received on 2010-09-21 14:50:14 CEST

This is an archived mail posted to the Subversion Dev mailing list.