Re: svn commit: r998880 - in /subversion/trunk/subversion: include/svn_error_codes.h include/svn_fs.h libsvn_fs_base/revs-txns.c libsvn_fs_fs/fs_fs.c tests/libsvn_fs/fs-test.c

On 09/20/2010 03:36 AM, danielsh_at_apache.org wrote:
> Author: danielsh
> Date: Mon Sep 20 10:36:29 2010
> New Revision: 998880
>
> URL: http://svn.apache.org/viewvc?rev=998880&view=rev
> Log:
> Use a new, distinct error code if svn_fs_change_rev_prop2's old_value_p
> doesn't match.
>
> * subversion/include/svn_error_codes.h
> (SVN_ERR_BAD_OLD_VALUE): New error code.

I wouldn't call it a "BAD" old value, it's just an outdated old value.

Just some ideas here, maybe move it out of the
SVN_ERR_BAD_CATEGORY_START into SVN_ERR_MISC_CATEGORY_START or
SVN_ERR_FS_CATEGORY_START?

There's a SVN_ERR_FS_REP_CHANGED error, maybe use
SVN_ERR_FS_PROPERTY_CHANGED?

Or using SVN_ERR_FS_TXN_OUT_OF_DATE as a model,
SVN_ERR_FS_PROPERTY_VALUE_OUT_OF_DATE?

Blair
Received on 2010-09-20 21:02:23 CEST