[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH 1/3] atomic-revprop: Change error name

From: Jon Foster <Jon.Foster_at_cabot.co.uk>
Date: Mon, 20 Sep 2010 10:47:05 +0100


I'm keen to get the atomic-revprop feature working, so I've had a
go at writing patches for some of the missing bits.

This first patch gives a unique error code for the case where the
old_value passed to the revprop change function doesn't match the
real old value. This allows it to be detected easily. (The
branch currently overloads SVN_ERR_BAD_PROPERTY_VALUE for this,
but the same error code is also used if the new value is illegal).

This feature is on the BRANCH-README's TODO list.

The patch is against the atomic-revprop branch, but it also
applies to trunk.

Use a new, distinct error code if svn_fs_change_rev_prop2's old_value_p
doesn't match.

* subversion/include/svn_error_codes.h:
  (SVN_ERR_BAD_OLD_VALUE): New error code.

* subversion/libsvn_fs_fs/fs_fs.c:
  (change_rev_prop_body): Use SVN_ERR_BAD_OLD_VALUE when appropriate.

* subversion/libsvn_fs_base/revs-txns.c:
  (svn_fs_base__set_rev_prop): Use SVN_ERR_BAD_OLD_VALUE when

* subversion/include/svn_fs.h:
  (svn_fs_change_rev_prop2): Update documentation.

* subversion/tests/libsvn_fs/fs-test.c:
  (FAILS_WITH_BPV): Rename to...
  (FAILS_WITH_BOV): ... this. Change to test for SVN_ERR_BAD_OLD_VALUE.
  (revision_props): Change to use FAILS_WITH_BOV instead of

Patch by: Jon Foster <jon.foster_at_cabot.co.uk>

Kind regards,


This email and its attachments may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of Cabot Communications Ltd.

If you are not the intended recipient of this email and its attachments, you must take no action based upon them, nor must you copy or show them to anyone.

Cabot Communications Limited
Verona House, Filwood Road, Bristol BS16 3RY, UK
+44 (0) 1179584232

Co. Registered in England number 02817269

Please contact the sender if you believe you have received this email in error.


This email has been scanned by the MessageLabs Email Security System.
For more information please visit http://www.messagelabs.com/email

Received on 2010-09-20 11:49:33 CEST

This is an archived mail posted to the Subversion Dev mailing list.