[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r997403 - /subversion/trunk/subversion/libsvn_wc/wc-metadata.sql

From: Greg Stein <gstein_at_gmail.com>
Date: Wed, 15 Sep 2010 16:17:18 -0400

On Wed, Sep 15, 2010 at 13:19, <julianfoad_at_apache.org> wrote:
>...
> -    - ### A comment on 'repos_id' and 'repos_relpath' says they may be null;
> -      is this true and wanted?

Yes. That meant "use the parent's information, and extend it to
compute this node's value".

> +    - The Node-Rev group points to the corresponding repository node-rev.
>
> -    - ### A comment on 'revnum' says, "this could be NULL for non-present
> -      nodes -- no info"; is this true and wanted?
> +    - If not used (as specified by the 'presence' table above), the values
> +      are undefined.
> +      ### Perhaps we should set them to null to make it clearer.

Yes, we should.

>
>   Content columns: (kind, properties, depth, target, checksum)
>                     ----  ----------  -----  ------  --------
> @@ -165,6 +177,7 @@ Overview of BASE_NODE columns:
>     - Includes a copy of the corresponding date and author rev-props.
>
>     - If not used (as specified by the 'presence' table above), all null.
> +      ### Not checked; in practice these columns may have undefined values.

They should never be undefined. They should be null.

We should never have undefined information in our schema. That leads
to madness...

Cheers,
-g
Received on 2010-09-15 22:18:12 CEST

This is an archived mail posted to the Subversion Dev mailing list.