Re: svn commit: r997249 - in /subversion/trunk/subversion: include/svn_client.h libsvn_client/patch.c svn/cl.h svn/main.c svn/patch-cmd.c tests/cmdline/patch_tests.py tests/libsvn_client/client-test.c

On Wed, Sep 15, 2010 at 08:53:17PM +0200, Hyrum K. Wright wrote:
> How about just adding '--patch-left' and '--patch-right' or something.
> The either both have to used, or neither, and if they are, use those
> names as the once in the patch.

I don't like these names because it's not clear what left and right refer to.
Also, why would you need to use both these options together?

> If people can use the UNIX diff tool
> to create left/right names they just made up, let's just let them
> worry about feeding those names back into Subversion (rather than
> guessing).

One goal of svn patch is to facilitate application of arbitrary unidiffs.
The person generating the patch may not be the same person worrying
about applying the patch to a Subversion working copy.

In any case, people can always edit the patch file. But having an option
like this saves a bit of manual edits in the cases described.

Stefan
Received on 2010-09-15 21:16:53 CEST