[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r995475 - /subversion/trunk/subversion/libsvn_repos/load.c

From: Stefan Sperling <stsp_at_elego.de>
Date: Wed, 15 Sep 2010 21:03:51 +0200

On Fri, Sep 10, 2010 at 04:02:52PM +0200, Branko Čibej wrote:
> On 10.09.2010 15:26, Stefan Sperling wrote:
> > I know we're using C89, but maybe it's time to move on and upgrade to C99
> > where the benefits are desirable? When Subversion was started, C89 was about
> > a decade old, and C99 is just as old now...
>
> Microsoft's C compiler, to name only one, still does not provide most of
> the C99 features. I don't know about standard library support.
>
> However, I don't see where you gain with using strtol(). First of all,
> it was already in C89 and has effectively the same interface as the APR
> conversions. C99 added strtoll() but it has the same interface. What's
> the benefit?

Raising this thread again, because there is a benefit to using strtol()'s
unsigned cousin, strtoul(). APR does not provide an interface for it.
Can we use it? Can we also use its 64-bit cousin strtoull()? If we can use
those two, we might as well use strtol() and strtoul() and skip apr_strtoi64()
completely.

Stefan
Received on 2010-09-15 21:04:47 CEST

This is an archived mail posted to the Subversion Dev mailing list.