[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

In svn_subst_translate_string(), shouldn't REPAIR in the call to svn_subst_translate_cstring2() be TRUE?

From: Daniel Trebbien <dtrebbien_at_gmail.com>
Date: Mon, 13 Sep 2010 15:55:58 -0700

Looking through the source code for `svn_subst_translate_string` in
`subversion/libsvn_subr/subst.c`, it seems odd to me that the `repair`
parameter to the call to `svn_subst_translate_cstring2` (for
translating the line endings) is `FALSE`. `FALSE` means that if the
line endings are inconsistent, then `svn_subst_translate_cstring2`
fails.

Given that the documentation for `svn_subst_translate_string` says
that `value` is translated to LF line endings, which implies to me
that all line endings are changed to Unix-style, shouldn't
`svn_subst_translate_cstring2` be called with `repair` set to `TRUE`?
Received on 2010-09-14 00:56:37 CEST

This is an archived mail posted to the Subversion Dev mailing list.