[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Test case for issue #3471: svn up touches file w/ lock & svn:keywords property

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Mon, 13 Sep 2010 10:53:17 +0100

Senthil Kumaran S <senthil_at_collab.net> writes:

> In the previous versions of subversion ie., 1.5.x or 1.4.x the keyword
> will not expand, but this is not the case with 1.6.x in which it gets
> expanded for the first update. This is what the issue #3471 is about
> and the committed patch tests that.

I'm still confused. The test creates an unexpanded keyword and then
runs update and the keyword gets expanded. Are you saying that update
should not expand the keyword, because that's the way 1.5 behaved?

I think it's right that update expands the keyword, and so when the
timestamp changes that is also correct.

What is a bug is that a *second* update causes the file's timestamp to
get changed a second time. A second update doesn't change the file
contents and so the timestamp should not change. But the test doesn't
run a second update. If the test did run a second update it could use
do_sleep_for_timestamps rather than sleep.

-- 
Philip
Received on 2010-09-13 11:54:01 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.