[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r995383 - /subversion/trunk/subversion/libsvn_fs_fs/fs_fs.c

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Thu, 9 Sep 2010 15:20:17 +0300

stsp_at_apache.org wrote on Thu, Sep 09, 2010 at 11:31:13 -0000:
> + return svn_error_return(
> + svn_error_create(SVN_ERR_FS_CORRUPT, NULL,
> + _("Malformed representation header")));

svn_error_return() isn't necessary here, since svn_error_create()
has always recorded the file-line coordinates.

That's unlike, say, svn_error_compose_create(), which doesn't record the
file-line coordinates; thus,

    err1 = foo();
    err2 = bar();
    return svn_error_return(svn_error_compose_create(err1, err2));

isn't redundant.
Received on 2010-09-09 14:24:15 CEST

This is an archived mail posted to the Subversion Dev mailing list.