On Thu, 2010-09-09 at 13:08 +0530, Senthil Kumaran S wrote:
> Hi Vijay,
> vijayaguru wrote:
> > The attached patch adds a test case for issue #3471:svn up touches file
> > w/ lock & svn:keywords property and marking it as 'XFail' until the
> > issue is fixed.
> Thanks for the patch. I reviewed it and I could see the patch does not test the
> actual problem. The issue says the timestamp changes for the file hence 'make'
> rebuilds stuff. In this case you have tested whether the keyword is expanded or
> not, which is a valid check for this use case, but apart from that you must
> also test whether an update happens for the file or not, because if someone
> fixes the keyword expansion thingy, and still something else causes an update
> of the file's timestamp, that is also not acceptable, since 1.4.x didn't behave
> in such a way. Hence do a check for timestamp on the file after an update.
> PS: See that all lines in your patch is within 79 columns.
> Thank You.
Thanks senthil. The attached patch tests the timestamp changes before
and after "svn up" and raises failure if they are not same.
Add a test for issue #3471:'svn up touches file w/ lock &
(update_with_file_lock_and_keywords_property_set): New test case.
(test_list): Add update_with_file_lock_and_keywords_property_set and
mark it as XFail.
Thanks & Regards,
Received on 2010-09-09 12:31:41 CEST