[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r993183 - in /subversion/trunk/subversion: include/ libsvn_diff/ libsvn_ra_serf/ libsvn_subr/ mod_dav_svn/reports/

From: Stefan Sperling <stsp_at_elego.de>
Date: Tue, 7 Sep 2010 12:14:03 +0200

On Tue, Sep 07, 2010 at 09:17:10AM +0200, Stephen Butler wrote:
> >> * subversion/include/svn_string.h
> >> (svn_cstring_strtoi64, svn_cstring_atoi64, svn_cstring_atoi,
> >> svn_cstring_strtoui64, svn_cstring_atoui64, svn_cstring_atoui): Declare.
>
> Uh oh, some buildbots complain about APR_UINT{32,64}_MAX being
> undefined. It looks like they were first defined in APR 1.3.

Philip has fixed this.

> >> * subversion/libsvn_subr/svn_string.c
> >> (): Include svn_private_config.h for the _() gettext macro.
> >> (svn_cstring_strtoi64, svn_cstring_strtoui64, svn_cstring_atoi64,
> >> svn_cstring_atoi): New.
> >>
> >> * subversion/libsvn_ra_serf/serf.c
> >> (dirent_walker): Use svn_cstring_atoi64() instead of apr_atoi64().
> >>
> >> * subversion/libsvn_diff/parse-diff.c
> >> (parse_offset): Call svn_cstring_strtoui64() instead of calling
> >> apr_atoi64() and performing manual overflow checking.
> >>
> >> * subversion/mod_dav_svn/reports/log.c
> >> (dav_svn__log_report): Use svn_cstring_atoi() instead of atoi() for
> >> parsing CDATA of the "limit" element.
>
> subversion/mod_dav_svn/reports/log.c:320: warning: implicit declaration of function ‘malformed_element_error’
>
> I get just a warning, but this is an error on some buildbots.
>
> FWIW, copy-pasting the static function from replay.c makes the
> compiler happy.

See r993310.

All that's left is fallout in the patch code on non-64 bit machines,
will look into that now.

Thanks,
Stefan
Received on 2010-09-07 12:15:23 CEST

This is an archived mail posted to the Subversion Dev mailing list.